From 1a52e592e5354a5c2f159ec68feb5028a22f8a2d Mon Sep 17 00:00:00 2001
From: Patrick de Ruiter <pderuiter@bsdserver.nl>
Date: Sun, 2 Nov 2025 13:13:31 +0100
Subject: [PATCH] Remove non-functional Terraform provider caching

Issue:
- Cache steps were timing out after ~5 minutes with ETIMEDOUT errors
- Gitea Actions cache server not configured or not responding
- Connection attempts to 172.19.0.3:36175 failing
- Added 8-10 minutes of unnecessary delays to pipeline

Solution:
- Removed 'Cache Terraform Providers' step from terraform-init job
- Removed 'Restore Terraform Cache' step from terraform-apply job
- Terraform init will download providers fresh each time
- No performance degradation since cache was never working

Impact:
- Faster pipeline execution (removes timeout delays)
- No functional changes (cache was never successful)
- Apply job still independent and self-contained

Note: terraform-vsphere-network never had cache steps (copied before caching was added)
---
 .gitea/workflows/sonarqube.yaml | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/.gitea/workflows/sonarqube.yaml b/.gitea/workflows/sonarqube.yaml
index cb581d8..581ac7e 100644
--- a/.gitea/workflows/sonarqube.yaml
+++ b/.gitea/workflows/sonarqube.yaml
@@ -92,16 +92,6 @@ jobs:
       with:
         terraform_version: latest
 
-    - name: Cache Terraform Providers
-      uses: actions/cache@v3
-      with:
-        path: |
-          .terraform
-          .terraform.lock.hcl
-        key: terraform-${{ hashFiles('**/.terraform.lock.hcl') }}
-        restore-keys: |
-          terraform-
-
     - name: Terraform Init
       env:
         AWS_ACCESS_KEY_ID: ${{ secrets.MINIO_ACCESS_KEY }}
@@ -178,16 +168,6 @@ jobs:
       with:
         terraform_version: latest
 
-    - name: Restore Terraform Cache
-      uses: actions/cache@v3
-      with:
-        path: |
-          .terraform
-          .terraform.lock.hcl
-        key: terraform-${{ hashFiles('**/.terraform.lock.hcl') }}
-        restore-keys: |
-          terraform-
-
     - name: Install AWS CLI
       run: |
         curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"