fix: Only set DNS if dns_servers list is not empty
All checks were successful
Code Quality & Security Scan / TFLint (push) Successful in 20s
Code Quality & Security Scan / Terraform Destroy (push) Has been skipped
Code Quality & Security Scan / Tfsec Security Scan (push) Successful in 22s
Code Quality & Security Scan / Checkov Security Scan (push) Successful in 37s
Code Quality & Security Scan / Terraform Validate (push) Successful in 32s
Code Quality & Security Scan / SonarQube Scan (push) Successful in 43s
Code Quality & Security Scan / Terraform Plan (push) Successful in 1m16s
Code Quality & Security Scan / Terraform Apply (push) Successful in 1m21s

Changed dns configuration to use conditional assignment to avoid
setting empty DNS list which Docker might ignore.

Changes:
- dns = length(var.dns_servers) > 0 ? var.dns_servers : null

This ensures that:
- If dns_servers is empty, dns is set to null (Docker uses defaults)
- If dns_servers has values, they are properly applied to container
This commit is contained in:
Patrick de Ruiter 2025-11-20 10:21:25 +01:00
parent 89f0029d67
commit 56e15bd594
Signed by: pderuiter
GPG Key ID: 5EBA7F21CF583321

View File

@ -50,7 +50,8 @@ resource "docker_container" "renovate" {
} }
# DNS configuration for internal hostname resolution # DNS configuration for internal hostname resolution
dns = var.dns_servers # Only set if dns_servers is not empty
dns = length(var.dns_servers) > 0 ? var.dns_servers : null
# Volumes # Volumes
volumes { volumes {