MON-237 Remove Cosmos DB no request monitor

cloud/azure/README.md

@@ -91,8 +91,6 @@ Inputs
 | cosmos_db_5xx_request_rate_threshold_warning | Warning threshold for Cosmos DB 5xx requests monitor | string | `50` | no |
 | cosmos_db_5xx_requests_message | Custom message for Cosmos DB 5xx requests monitor | string | `` | no |
 | cosmos_db_5xx_requests_silenced | Groups to mute for Cosmos DB 5xx requests monitor | map | `<map>` | no |
-| cosmos_db_no_request_message | Custom message for Cosmos DB no request monitor | string | `` | no |
-| cosmos_db_no_request_silenced | Groups to mute for Cosmos DB no request monitor | map | `<map>` | no |
 | cosmos_db_ru_utilization_collection | Group to associate Cosmos DB collection to RU max | map | - | yes |
 | cosmos_db_ru_utilization_message | Custom message for Cosmos DB collection RU utilization monitor | string | `` | no |
 | cosmos_db_ru_utilization_rate_threshold_critical | Critical threshold for Cosmos DB collection RU utilization monitor | string | `90` | no |

cloud/azure/cosmosdb/README.md

@@ -25,7 +25,6 @@ Creates DataDog monitors with the following checks:
 - Cosmos DB 4xx requests rate is high
 - Cosmos DB 5xx requests rate is high
 - Cosmos DB collection ${element(keys(var.cosmos_db_ru_utilization_collections),count.index)} RU utilization is high
-- Cosmos DB has no request
 - Cosmos DB is down
 
 ## Inputs
@@ -48,12 +47,6 @@ Creates DataDog monitors with the following checks:
 | cosmos_db_5xx_requests_enabled | Flag to enable Cosmos DB 5xx requests monitor | string | `true` | no |
 | cosmos_db_5xx_requests_message | Custom message for Cosmos DB 5xx requests monitor | string | `` | no |
 | cosmos_db_5xx_requests_silenced | Groups to mute for Cosmos DB 5xx requests monitor | map | `<map>` | no |
-| cosmos_db_no_request_enabled | Flag to enable Cosmos DB no request monitor | string | `true` | no |
-| cosmos_db_no_request_extra_tags | Extra tags for Cosmos DB no request monitor | list | `<list>` | no |
-| cosmos_db_no_request_message | Custom message for Cosmos DB no request monitor | string | `` | no |
-| cosmos_db_no_request_silenced | Groups to mute for Cosmos DB no request monitor | map | `<map>` | no |
-| cosmos_db_no_request_time_aggregator | Monitor aggregator for Cosmos DB no request [available values: min, max or avg] | string | `max` | no |
-| cosmos_db_no_request_timeframe | Monitor timeframe for Cosmos DB no request [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `last_5m` | no |
 | cosmos_db_ru_utilization_collections | Group to associate Cosmos DB collection to RU max. RU value has to be correlated with the monitor timeframe | map | - | yes |
 | cosmos_db_ru_utilization_enabled | Flag to enable Cosmos DB collection RU utilization monitor | string | `true` | no |
 | cosmos_db_ru_utilization_extra_tags | Extra tags for Cosmos DB collection RU utilization monitor | list | `<list>` | no |
@@ -84,7 +77,6 @@ Creates DataDog monitors with the following checks:
 | cosmos_db_5xx_requests_id | id for monitor cosmos_db_5xx_requests |
 | cosmos_db_ru_utilization_id | id for monitor cosmos_db_ru_utilization |
 | cosmos_db_status_id | id for monitor cosmos_db_status |
-| cosmos_db_success_no_data_id | id for monitor cosmos_db_success_no_data |
 
 Related documentation
 ---------------------

cloud/azure/cosmosdb/inputs.tf

@@ -156,42 +156,6 @@ variable "cosmos_db_5xx_request_timeframe" {
   default     = "last_5m"
 }
 
-variable "cosmos_db_no_request_message" {
-  description = "Custom message for Cosmos DB no request monitor"
-  type        = "string"
-  default     = ""
-}
-
-variable "cosmos_db_no_request_enabled" {
-  description = "Flag to enable Cosmos DB no request monitor"
-  type        = "string"
-  default     = "true"
-}
-
-variable "cosmos_db_no_request_silenced" {
-  description = "Groups to mute for Cosmos DB no request monitor"
-  type        = "map"
-  default     = {}
-}
-
-variable "cosmos_db_no_request_extra_tags" {
-  description = "Extra tags for Cosmos DB no request monitor"
-  type        = "list"
-  default     = []
-}
-
-variable "cosmos_db_no_request_time_aggregator" {
-  description = "Monitor aggregator for Cosmos DB no request [available values: min, max or avg]"
-  type        = "string"
-  default     = "max"
-}
-
-variable "cosmos_db_no_request_timeframe" {
-  description = "Monitor timeframe for Cosmos DB no request [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`]"
-  type        = "string"
-  default     = "last_5m"
-}
-
 variable "cosmos_db_ru_utilization_message" {
   description = "Custom message for Cosmos DB collection RU utilization monitor"
   type        = "string"

cloud/azure/cosmosdb/monitors-cosmosdb.tf

@@ -134,36 +134,6 @@ resource "datadog_monitor" "cosmos_db_5xx_requests" {
   tags = ["env:${var.environment}", "type:cloud", "provider:azure", "resource:cosmos_db", "team:claranet", "created-by:terraform", "${var.cosmos_db_5xx_request_rate_extra_tags}"]
 }
 
-resource "datadog_monitor" "cosmos_db_success_no_data" {
-  count = "${var.cosmos_db_no_request_enabled ? 1 : 0}"
-
-  name    = "[${var.environment}] Cosmos DB has no request"
-  message = "${coalesce(var.cosmos_db_no_request_message, var.message)}"
-
-  query = <<EOF
-      ${var.cosmos_db_no_request_time_aggregator}(${var.cosmos_db_no_request_timeframe}): (
-        avg:azure.cosmosdb.total_requests${module.filter-tags.query_alert} by {resource_group,region,name,collectionname} +
-        avg:azure.documentdb_databaseaccounts.total_requests${module.filter-tags.query_alert} by {resource_group,region,name,collectionname}
-      ) < 0
-  EOF
-
-  type = "metric alert"
-
-  silenced = "${var.cosmos_db_no_request_silenced}"
-
-  notify_no_data      = true
-  evaluation_delay    = "${var.evaluation_delay}"
-  renotify_interval   = 0
-  notify_audit        = false
-  timeout_h           = 0
-  include_tags        = true
-  locked              = false
-  require_full_window = true
-  new_host_delay      = "${var.new_host_delay}"
-
-  tags = ["env:${var.environment}", "type:cloud", "provider:azure", "resource:cosmos_db", "team:claranet", "created-by:terraform", "${var.cosmos_db_no_request_extra_tags}"]
-}
-
 resource "datadog_monitor" "cosmos_db_ru_utilization" {
   count = "${var.cosmos_db_ru_utilization_enabled ? length(var.cosmos_db_ru_utilization_collections) : 0}"
 

cloud/azure/cosmosdb/outputs.tf

@@ -13,11 +13,6 @@ output "cosmos_db_5xx_requests_id" {
   value       = "${datadog_monitor.cosmos_db_5xx_requests.*.id}"
 }
 
-output "cosmos_db_success_no_data_id" {
-  description = "id for monitor cosmos_db_success_no_data"
-  value       = "${datadog_monitor.cosmos_db_success_no_data.*.id}"
-}
-
 output "cosmos_db_ru_utilization_id" {
   description = "id for monitor cosmos_db_ru_utilization"
   value       = "${datadog_monitor.cosmos_db_ru_utilization.*.id}"

cloud/azure/inputs.tf

@@ -1751,42 +1751,6 @@ variable "cosmos_db_5xx_request_timeframe" {
   default     = "last_5m"
 }
 
-variable "cosmos_db_no_request_message" {
-  description = "Custom message for Cosmos DB no request monitor"
-  type        = "string"
-  default     = ""
-}
-
-variable "cosmos_db_no_request_enabled" {
-  description = "Flag to enable Cosmos DB no request monitor"
-  type        = "string"
-  default     = "true"
-}
-
-variable "cosmos_db_no_request_silenced" {
-  description = "Groups to mute for Cosmos DB no request monitor"
-  type        = "map"
-  default     = {}
-}
-
-variable "cosmos_db_no_request_extra_tags" {
-  description = "Extra tags for Cosmos DB no request monitor"
-  type        = "list"
-  default     = []
-}
-
-variable "cosmos_db_no_request_time_aggregator" {
-  description = "Monitor aggregator for Cosmos DB no request [available values: min, max or avg]"
-  type        = "string"
-  default     = "max"
-}
-
-variable "cosmos_db_no_request_timeframe" {
-  description = "Monitor timeframe for Cosmos DB no request [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`]"
-  type        = "string"
-  default     = "last_5m"
-}
-
 variable "cosmos_db_ru_utilization_message" {
   description = "Custom message for Cosmos DB collection RU utilization monitor"
   type        = "string"

cloud/azure/monitors.tf

@@ -423,13 +423,6 @@ module "cosmosdb" {
   cosmos_db_5xx_request_time_aggregator         = "${var.cosmos_db_5xx_request_time_aggregator}"
   cosmos_db_5xx_request_timeframe               = "${var.cosmos_db_5xx_request_timeframe}"
 
-  cosmos_db_no_request_enabled         = "${var.cosmos_db_no_request_enabled}"
-  cosmos_db_no_request_message         = "${var.cosmos_db_no_request_message}"
-  cosmos_db_no_request_silenced        = "${var.cosmos_db_no_request_silenced}"
-  cosmos_db_no_request_extra_tags      = "${var.cosmos_db_no_request_extra_tags}"
-  cosmos_db_no_request_time_aggregator = "${var.cosmos_db_no_request_time_aggregator}"
-  cosmos_db_no_request_timeframe       = "${var.cosmos_db_no_request_timeframe}"
-
   cosmos_db_ru_utilization_enabled                 = "${var.cosmos_db_ru_utilization_enabled}"
   cosmos_db_ru_utilization_rate_threshold_critical = "${var.cosmos_db_ru_utilization_rate_threshold_critical}"
   cosmos_db_ru_utilization_rate_threshold_warning  = "${var.cosmos_db_ru_utilization_rate_threshold_warning}"