MON-91 - Update PR to follow recommandations

cloud/aws/vpn/inputs.tf

@@ -1 +0,0 @@
-../../../inputs.tf

cloud/aws/vpn/inputs.tf

@@ -0,0 +1,19 @@
+variable env {}
+
+variable "vpn_tunnel_address" {
+  description = "List the VPN tunnels you want to monitor"
+  type        = "list"
+  default     = []
+}
+
+variable "vpn_config" {
+  description = "Ok means that both tunnels are up, warning means only one tunnel is up and critical means that both tunnels are down "
+  type        = "map"
+
+  default = {
+    delay    = 900
+    warning  = 1
+    critical = 0
+    ok       = 2
+  }
+}

cloud/aws/vpn/monitors-vpn.tf

@@ -24,7 +24,7 @@ resource "datadog_monitor" "VPN_status" {
   }
 
   notify_no_data      = true
-  renotify_interval   = 15
+  renotify_interval   = 0
   evaluation_delay    = "${var.vpn_config["delay"]}"
   notify_audit        = false
   timeout_h           = 0

inputs.tf

@@ -109,25 +109,6 @@ variable "elb_backend_latency" {
   }
 }
 
-## VPN
-variable "vpn_tunnel_address" {
-  description = "List the VPN tunnels you want to monitor"
-  type        = "list"
-  default     = []
-}
-
-variable "vpn_config" {
-  description = "Ok means that both tunnels are up, warning means only one tunnel is up and critical means that both tunnels are down "
-  type        = "map"
-
-  default = {
-    delay    = 900
-    warning  = 1
-    critical = 0
-    ok       = 2
-  }
-}
-
 ##apache nginx php
 variable "dd_nginx" {
   default = "disabled"