wbyc/terraform-datadog-old-monitors
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MON-476 fmt and add one no data per set as best practice in ci

Browse Source
This commit is contained in:
Quentin Manfroi 2019-06-14 15:12:34 +02:00
parent 5cbf1bbdab
commit da324c10b3
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cloud/azure/azure-search/monitors-azure-search.tf
View File

@ -53,7 +53,7 @@ resource "datadog_monitor" "azure_search_throttled_queries_rate" {
silenced = "${var.throttled_queries_rate_silenced}" silenced = "${var.throttled_queries_rate_silenced}"
notify_no_data = false # Will notify when no data is received notify_no_data = false # Will notify when no data is received
renotify_interval = 0 renotify_interval = 0
require_full_window = false require_full_window = false
timeout_h = 0 timeout_h = 0

14
scripts/90_best_practices.sh Executable file
View File

@ -0,0 +1,14 @@
#!/bin/bash
set -xueo pipefail
source "$(dirname $0)/utils.sh"
goto_root
# loop over every monitors set
for path in $(find "$(get_scope $1)" -path ./incubator -prune -o -name 'monitors-*.tf' -print | sort -fdbi); do
# check if there is more than 1 notify_no_data parameter set to true per set of monitors
if [[ $(grep -c notify_no_data.*true $path) -gt 1 ]]; then
echo "More than one notify_no_data set to true on $path"
exit 1
fi
done