From a682ae5b523fd20857547e78f725b606ef09630c Mon Sep 17 00:00:00 2001
From: Quentin Manfroi <quentin.manfroi@fr.clara.net>
Date: Thu, 9 May 2019 18:17:07 +0200
Subject: [PATCH] MON-444 fix operator and timeframe for pod error monitor

---
 caas/kubernetes/pod/README.md           | 2 +-
 caas/kubernetes/pod/inputs.tf           | 2 +-
 caas/kubernetes/pod/monitors-k8s-pod.tf | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/caas/kubernetes/pod/README.md b/caas/kubernetes/pod/README.md
index 50d0946..7e26052 100644
--- a/caas/kubernetes/pod/README.md
+++ b/caas/kubernetes/pod/README.md
@@ -30,7 +30,7 @@ Creates DataDog monitors with the following checks:
 | error\_silenced | Groups to mute for Pod errors monitor | map | `{}` | no |
 | error\_threshold\_critical | error critical threshold | string | `"0.5"` | no |
 | error\_threshold\_warning | error warning threshold | string | `"0"` | no |
-| error\_time\_aggregator | Monitor aggregator for Pod errors [available values: min, max or avg] | string | `"sum"` | no |
+| error\_time\_aggregator | Monitor aggregator for Pod errors [available values: min, max or avg] | string | `"min"` | no |
 | error\_timeframe | Monitor timeframe for Pod errors [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `"last_15m"` | no |
 | evaluation\_delay | Delay in seconds for the metric evaluation | string | `"15"` | no |
 | filter\_tags\_custom | Tags used for custom filtering when filter_tags_use_defaults is false | string | `"*"` | no |
diff --git a/caas/kubernetes/pod/inputs.tf b/caas/kubernetes/pod/inputs.tf
index 0c9ef8e..2c28fdf 100644
--- a/caas/kubernetes/pod/inputs.tf
+++ b/caas/kubernetes/pod/inputs.tf
@@ -103,7 +103,7 @@ variable "error_message" {
 variable "error_time_aggregator" {
   description = "Monitor aggregator for Pod errors [available values: min, max or avg]"
   type        = "string"
-  default     = "sum"
+  default     = "min"
 }
 
 variable "error_timeframe" {
diff --git a/caas/kubernetes/pod/monitors-k8s-pod.tf b/caas/kubernetes/pod/monitors-k8s-pod.tf
index e0c8896..e760f56 100644
--- a/caas/kubernetes/pod/monitors-k8s-pod.tf
+++ b/caas/kubernetes/pod/monitors-k8s-pod.tf
@@ -37,7 +37,7 @@ resource "datadog_monitor" "error" {
   query = <<EOQ
     ${var.error_time_aggregator}(${var.error_timeframe}):
       sum:kubernetes_state.container.status_report.count.waiting${module.filter-tags-nocontainercreating.query_alert} by {namespace,pod,reason}.as_count()
-    >= ${var.error_threshold_critical}
+    > ${var.error_threshold_critical}
   EOQ
 
   thresholds {