From 964e52f46b108070e5f2bc1934e3d0f54366df4a Mon Sep 17 00:00:00 2001
From: Laurent Piroelle <laurent.piroelle@fr.clara.net>
Date: Thu, 8 Feb 2018 17:16:35 +0100
Subject: [PATCH] MON-79 Remove notify no data on storage since no data is sent
 from Azure on unused storage accounts

---
 cloud/azure/storage/README.md                 |  3 ++-
 cloud/azure/storage/monitors-azure-storage.tf | 20 +++++++++----------
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/cloud/azure/storage/README.md b/cloud/azure/storage/README.md
index 7702683..b999f35 100644
--- a/cloud/azure/storage/README.md
+++ b/cloud/azure/storage/README.md
@@ -54,5 +54,6 @@ DataDog documentation: [https://docs.datadoghq.com/integrations/azure_storage/](
 
 DataDog blog: [https://www.datadoghq.com/blog/monitor-azure-storage-datadog/](https://www.datadoghq.com/blog/monitor-azure-storage-datadog/)
 
-Azure Redis metrics documentation: [https://docs.microsoft.com/en-us/azure/storage/common/storage-monitor-storage-account](https://docs.microsoft.com/en-us/azure/storage/common/storage-monitor-storage-account)
+Azure Storage metrics documentation: [https://docs.microsoft.com/en-us/azure/storage/common/storage-monitor-storage-account](https://docs.microsoft.com/en-us/azure/storage/common/storage-monitor-storage-account)
 
+Azure Storage metrics detailed documentation [https://docs.microsoft.com/en-us/rest/api/storageservices/storage-analytics-metrics-table-schema](https://docs.microsoft.com/en-us/rest/api/storageservices/storage-analytics-metrics-table-schema)
diff --git a/cloud/azure/storage/monitors-azure-storage.tf b/cloud/azure/storage/monitors-azure-storage.tf
index 0730013..0e5137c 100644
--- a/cloud/azure/storage/monitors-azure-storage.tf
+++ b/cloud/azure/storage/monitors-azure-storage.tf
@@ -7,7 +7,7 @@ data "template_file" "filter" {
 }
 
 resource "datadog_monitor" "availability" {
-  name    = "[${var.environment}] Azure Storage {{name}} unvailability detected"
+  name    = "[${var.environment}] Azure Storage {{name}} unavailability detected"
   message = "${var.message}"
 
   query = <<EOF
@@ -21,7 +21,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -50,7 +50,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -79,7 +79,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -108,7 +108,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -137,7 +137,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -166,7 +166,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -195,7 +195,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -224,7 +224,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true
@@ -253,7 +253,7 @@ EOF
   }
 
   type                = "metric alert"
-  notify_no_data      = true
+  notify_no_data      = false
   notify_audit        = false
   timeout_h           = 0
   include_tags        = true