From 84495256a95d7e26605ec517c1efc236aaa3f301 Mon Sep 17 00:00:00 2001 From: Rafael Romero Carmona Date: Wed, 27 Jun 2018 12:17:09 +0200 Subject: [PATCH] MON-32 Removed non used parameters nodes and elasticache_size --- cloud/aws/elasticache/memcached/README.md | 3 +-- cloud/aws/elasticache/memcached/inputs.tf | 6 ------ cloud/aws/elasticache/redis/README.md | 5 ++--- cloud/aws/elasticache/redis/inputs.tf | 11 ----------- 4 files changed, 3 insertions(+), 22 deletions(-) diff --git a/cloud/aws/elasticache/memcached/README.md b/cloud/aws/elasticache/memcached/README.md index 83b0ca8..b744370 100644 --- a/cloud/aws/elasticache/memcached/README.md +++ b/cloud/aws/elasticache/memcached/README.md @@ -45,7 +45,6 @@ Inputs | cpu_high_time_aggregator | Monitor aggregator for Elasticache memcached cpu high [available values: min, max or avg] | string | `min` | no | | cpu_high_timeframe | Monitor timeframe for Elasticache memcached cpu high [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `last_15m` | no | | delay | Delay in seconds for the metric evaluation | string | `900` | no | -| elasticache_size | Size of the Elasticache instance | string | - | yes | | environment | Infrastructure Environment | string | - | yes | | eviction_growing_condition_timeframe | Monitor condition timeframe for Elasticache eviction growing [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `last_5m` | no | | eviction_growing_message | Custom message for Elasticache eviction growing monitor | string | `` | no | @@ -95,4 +94,4 @@ DataDog documentation: * [https://www.datadoghq.com/blog/monitoring-elasticache-performance-metrics-with-redis-or-memcached/](https://www.datadoghq.com/blog/monitoring-elasticache-performance-metrics-with-redis-or-memcached/) -AWS ElasticSearch Service Instance metrics documentation: [https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html) +AWS ElasticSearch Service Instance metrics documentation: [https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html) diff --git a/cloud/aws/elasticache/memcached/inputs.tf b/cloud/aws/elasticache/memcached/inputs.tf index 74c0e39..345e1f5 100644 --- a/cloud/aws/elasticache/memcached/inputs.tf +++ b/cloud/aws/elasticache/memcached/inputs.tf @@ -24,12 +24,6 @@ variable "filter_tags_custom" { default = "*" } -# elasticache variable -variable "elasticache_size" { - description = "Size of the Elasticache instance" - type = "string" -} - # Memcached specific variable "get_hits_silenced" { description = "Groups to mute for Elasticache memcached get hits monitor" diff --git a/cloud/aws/elasticache/redis/README.md b/cloud/aws/elasticache/redis/README.md index eea8930..7eb58ca 100644 --- a/cloud/aws/elasticache/redis/README.md +++ b/cloud/aws/elasticache/redis/README.md @@ -54,7 +54,6 @@ Inputs | cpu_high_time_aggregator | Monitor aggregator for Elasticache redis cpu high [available values: min, max or avg] | string | `avg` | no | | cpu_high_timeframe | Monitor timeframe for Elasticache redis cpu high [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `last_15m` | no | | delay | Delay in seconds for the metric evaluation | string | `900` | no | -| elasticache_size | Size of the Elasticache instance | string | - | yes | | environment | Infrastructure Environment | string | - | yes | | eviction_growing_condition_timeframe | Monitor condition timeframe for Elasticache eviction growing [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `last_5m` | no | | eviction_growing_message | Custom message for Elasticache eviction growing monitor | string | `` | no | @@ -83,7 +82,6 @@ Inputs | no_connection_silenced | Groups to mute for Elasticache no connection monitor | map | `` | no | | no_connection_time_aggregator | Monitor aggregator for Elasticache no connection [available values: min, max or avg] | string | `min` | no | | no_connection_timeframe | Monitor timeframe for Elasticache no connection [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `last_5m` | no | -| nodes | Number of Elasticache nodes | string | - | yes | | replication_lag_message | Custom message for Elasticache redis replication lag monitor | string | `` | no | | replication_lag_silenced | Groups to mute for Elasticache redis replication lag monitor | map | `` | no | | replication_lag_threshold_critical | Elasticache redis replication lag critical threshold in seconds | string | `1` | no | @@ -97,6 +95,7 @@ Inputs | swap_time_aggregator | Monitor aggregator for Elasticache memcached swap [available values: min, max or avg] | string | `min` | no | | swap_timeframe | Monitor timeframe for Elasticache swap [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `last_5m` | no | + Related documentation --------------------- @@ -106,4 +105,4 @@ DataDog documentation: * [https://www.datadoghq.com/dashboards/elasticache-dashboard-redis/](https://www.datadoghq.com/dashboards/elasticache-dashboard-redis/) * [https://www.datadoghq.com/blog/monitoring-elasticache-performance-metrics-with-redis-or-memcached/](https://www.datadoghq.com/blog/monitoring-elasticache-performance-metrics-with-redis-or-memcached/) -AWS ElasticSearch Service Instance metrics documentation: [https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html) +AWS ElasticSearch Service Instance metrics documentation: [https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/elasticache-metricscollected.html) diff --git a/cloud/aws/elasticache/redis/inputs.tf b/cloud/aws/elasticache/redis/inputs.tf index 255adff..a2baf75 100644 --- a/cloud/aws/elasticache/redis/inputs.tf +++ b/cloud/aws/elasticache/redis/inputs.tf @@ -24,17 +24,6 @@ variable "filter_tags_custom" { default = "*" } -# elasticache variable -variable "elasticache_size" { - description = "Size of the Elasticache instance" - type = "string" -} - -variable "nodes" { - description = "Number of Elasticache nodes" - type = "string" -} - # redis specific variable "cache_hits_silenced" { description = "Groups to mute for Elasticache redis cache hits monitor"