From bb7df320d8d2bf3de6182d72b34fbcb49cdcee06 Mon Sep 17 00:00:00 2001 From: Alexandre Gaillet Date: Tue, 19 Mar 2019 16:57:03 +0100 Subject: [PATCH 1/4] MON-418 Add Azure Load Balancer monitor --- README.md | 1 + cloud/azure/load-balancer/README.md | 47 +++++++++++++ cloud/azure/load-balancer/inputs.tf | 69 +++++++++++++++++++ cloud/azure/load-balancer/modules.tf | 31 +++++++++ .../load-balancer/monitors-load-balancer.tf | 28 ++++++++ cloud/azure/load-balancer/outputs.tf | 4 ++ 6 files changed, 180 insertions(+) create mode 100644 cloud/azure/load-balancer/README.md create mode 100644 cloud/azure/load-balancer/inputs.tf create mode 100644 cloud/azure/load-balancer/modules.tf create mode 100644 cloud/azure/load-balancer/monitors-load-balancer.tf create mode 100644 cloud/azure/load-balancer/outputs.tf diff --git a/README.md b/README.md index f1093fe..1641b86 100644 --- a/README.md +++ b/README.md @@ -105,6 +105,7 @@ The `//` is very important, it's a terraform specific syntax used to separate gi - [eventhub](https://git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors/tree/master/cloud/azure/eventhub/) - [iothubs](https://git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors/tree/master/cloud/azure/iothubs/) - [keyvault](https://git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors/tree/master/cloud/azure/keyvault/) + - [load-balancer](https://git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors/tree/master/cloud/azure/load-balancer/) - [mysql](https://git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors/tree/master/cloud/azure/mysql/) - [postgresql](https://git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors/tree/master/cloud/azure/postgresql/) - [redis](https://git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors/tree/master/cloud/azure/redis/) diff --git a/cloud/azure/load-balancer/README.md b/cloud/azure/load-balancer/README.md new file mode 100644 index 0000000..4e86602 --- /dev/null +++ b/cloud/azure/load-balancer/README.md @@ -0,0 +1,47 @@ +# CLOUD AZURE LOAD-BALANCER DataDog monitors + +## How to use this module + +``` +module "datadog-monitors-cloud-azure-load-balancer" { + source = "git::ssh://git@git.fr.clara.net/claranet/cloudnative/projects/datadog/terraform/monitors.git//cloud/azure/load-balancer?ref={revision}" + + environment = "${var.environment}" + message = "${module.datadog-message-alerting.alerting-message}" +} + +``` + +## Purpose + +Creates DataDog monitors with the following checks: + +- Load Balancer is down + +## Inputs + +| Name | Description | Type | Default | Required | +|------|-------------|:----:|:-----:|:-----:| +| environment | Architecture environment | string | n/a | yes | +| evaluation\_delay | Delay in seconds for the metric evaluation | string | `"900"` | no | +| filter\_tags\_custom | Tags used for custom filtering when filter_tags_use_defaults is false | string | `"*"` | no | +| filter\_tags\_custom\_excluded | Tags excluded for custom filtering when filter_tags_use_defaults is false | string | `""` | no | +| filter\_tags\_use\_defaults | Use default filter tags convention | string | `"true"` | no | +| message | Message sent when a monitor is triggered | string | n/a | yes | +| new\_host\_delay | Delay in seconds before monitor new resource | string | `"300"` | no | +| status\_enabled | Flag to enable Load Balancer status monitor | string | `"true"` | no | +| status\_extra\_tags | Extra tags for Load Balancer status monitor | list | `[]` | no | +| status\_message | Custom message for Load Balancer status monitor | string | `""` | no | +| status\_silenced | Groups to mute for Load Balancer status monitor | map | `{}` | no | +| status\_time\_aggregator | Monitor aggregator for Load Balancer status [available values: min, max or avg] | string | `"max"` | no | +| status\_timeframe | Monitor timeframe for Load Balancer status [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`] | string | `"last_5m"` | no | + +## Outputs + +| Name | Description | +|------|-------------| +| loadbalancer\_status\_id | id for monitor loadbalancer_status | + +## Related documentation + +DataDog documentation: [https://docs.datadoghq.com/integrations/azure/?tab=azurecliv20](https://docs.datadoghq.com/integrations/azure/?tab=azurecliv20) diff --git a/cloud/azure/load-balancer/inputs.tf b/cloud/azure/load-balancer/inputs.tf new file mode 100644 index 0000000..e92e504 --- /dev/null +++ b/cloud/azure/load-balancer/inputs.tf @@ -0,0 +1,69 @@ +variable "environment" { + description = "Architecture environment" + type = "string" +} + +variable "filter_tags_use_defaults" { + description = "Use default filter tags convention" + default = "true" +} + +variable "filter_tags_custom" { + description = "Tags used for custom filtering when filter_tags_use_defaults is false" + default = "*" +} + +variable "filter_tags_custom_excluded" { + description = "Tags excluded for custom filtering when filter_tags_use_defaults is false" + default = "" +} + +variable "message" { + description = "Message sent when a monitor is triggered" +} + +variable "evaluation_delay" { + description = "Delay in seconds for the metric evaluation" + default = 900 +} + +variable "new_host_delay" { + description = "Delay in seconds before monitor new resource" + default = 300 +} + +# Azure Load Balancer specific variables +variable "status_enabled" { + description = "Flag to enable Load Balancer status monitor" + type = "string" + default = "true" +} + +variable "status_silenced" { + description = "Groups to mute for Load Balancer status monitor" + type = "map" + default = {} +} + +variable "status_message" { + description = "Custom message for Load Balancer status monitor" + type = "string" + default = "" +} + +variable "status_time_aggregator" { + description = "Monitor aggregator for Load Balancer status [available values: min, max or avg]" + type = "string" + default = "max" +} + +variable "status_timeframe" { + description = "Monitor timeframe for Load Balancer status [available values: `last_#m` (1, 5, 10, 15, or 30), `last_#h` (1, 2, or 4), or `last_1d`]" + default = "last_5m" +} + +variable "status_extra_tags" { + description = "Extra tags for Load Balancer status monitor" + type = "list" + default = [] +} diff --git a/cloud/azure/load-balancer/modules.tf b/cloud/azure/load-balancer/modules.tf new file mode 100644 index 0000000..d89b7cd --- /dev/null +++ b/cloud/azure/load-balancer/modules.tf @@ -0,0 +1,31 @@ +module "filter-tags" { + source = "../../../common/filter-tags" + + environment = "${var.environment}" + resource = "azure_load-balancer" + filter_tags_use_defaults = "${var.filter_tags_use_defaults}" + filter_tags_custom = "${var.filter_tags_custom}" + filter_tags_custom_excluded = "${var.filter_tags_custom_excluded}" +} + +module "filter-tags-statuscode" { + source = "../../../common/filter-tags" + + environment = "${var.environment}" + resource = "azure_load-balancer" + filter_tags_use_defaults = "${var.filter_tags_use_defaults}" + filter_tags_custom = "${var.filter_tags_custom},statuscode:%s" + filter_tags_custom_excluded = "${var.filter_tags_custom_excluded}" + + extra_tags = ["statuscode:%s"] +} + +module "filter-tags-activity" { + source = "../../../common/filter-tags" + + environment = "${var.environment}" + resource = "azure_load-balancer" + filter_tags_use_defaults = "${var.filter_tags_use_defaults}" + filter_tags_custom = "${var.filter_tags_custom},!activityname:secretlist" + filter_tags_custom_excluded = "${var.filter_tags_custom_excluded}" +} diff --git a/cloud/azure/load-balancer/monitors-load-balancer.tf b/cloud/azure/load-balancer/monitors-load-balancer.tf new file mode 100644 index 0000000..e471bfa --- /dev/null +++ b/cloud/azure/load-balancer/monitors-load-balancer.tf @@ -0,0 +1,28 @@ +resource "datadog_monitor" "loadbalancer_status" { + count = "${var.status_enabled ? 1 : 0}" + + name = "[${var.environment}] Load Balancer is down" + message = "${coalesce(var.status_message, var.message)}" + + query = < Date: Tue, 19 Mar 2019 17:02:15 +0100 Subject: [PATCH 2/4] MON-418 Fix metric used --- cloud/azure/load-balancer/monitors-load-balancer.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cloud/azure/load-balancer/monitors-load-balancer.tf b/cloud/azure/load-balancer/monitors-load-balancer.tf index e471bfa..0df4351 100644 --- a/cloud/azure/load-balancer/monitors-load-balancer.tf +++ b/cloud/azure/load-balancer/monitors-load-balancer.tf @@ -6,7 +6,7 @@ resource "datadog_monitor" "loadbalancer_status" { query = < Date: Tue, 19 Mar 2019 17:54:30 +0100 Subject: [PATCH 3/4] MON-418 Clear modules --- cloud/azure/load-balancer/modules.tf | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/cloud/azure/load-balancer/modules.tf b/cloud/azure/load-balancer/modules.tf index d89b7cd..760e10f 100644 --- a/cloud/azure/load-balancer/modules.tf +++ b/cloud/azure/load-balancer/modules.tf @@ -7,25 +7,3 @@ module "filter-tags" { filter_tags_custom = "${var.filter_tags_custom}" filter_tags_custom_excluded = "${var.filter_tags_custom_excluded}" } - -module "filter-tags-statuscode" { - source = "../../../common/filter-tags" - - environment = "${var.environment}" - resource = "azure_load-balancer" - filter_tags_use_defaults = "${var.filter_tags_use_defaults}" - filter_tags_custom = "${var.filter_tags_custom},statuscode:%s" - filter_tags_custom_excluded = "${var.filter_tags_custom_excluded}" - - extra_tags = ["statuscode:%s"] -} - -module "filter-tags-activity" { - source = "../../../common/filter-tags" - - environment = "${var.environment}" - resource = "azure_load-balancer" - filter_tags_use_defaults = "${var.filter_tags_use_defaults}" - filter_tags_custom = "${var.filter_tags_custom},!activityname:secretlist" - filter_tags_custom_excluded = "${var.filter_tags_custom_excluded}" -} From 586e8218c2f1d46d2573cf269754df973ae99908 Mon Sep 17 00:00:00 2001 From: Alexandre Gaillet Date: Fri, 5 Apr 2019 10:05:34 +0200 Subject: [PATCH 4/4] MON-418 Change monitor name --- cloud/azure/load-balancer/README.md | 2 +- cloud/azure/load-balancer/monitors-load-balancer.tf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cloud/azure/load-balancer/README.md b/cloud/azure/load-balancer/README.md index 4e86602..102161a 100644 --- a/cloud/azure/load-balancer/README.md +++ b/cloud/azure/load-balancer/README.md @@ -16,7 +16,7 @@ module "datadog-monitors-cloud-azure-load-balancer" { Creates DataDog monitors with the following checks: -- Load Balancer is down +- Load Balancer is unreachable ## Inputs diff --git a/cloud/azure/load-balancer/monitors-load-balancer.tf b/cloud/azure/load-balancer/monitors-load-balancer.tf index 0df4351..2a69b90 100644 --- a/cloud/azure/load-balancer/monitors-load-balancer.tf +++ b/cloud/azure/load-balancer/monitors-load-balancer.tf @@ -1,7 +1,7 @@ resource "datadog_monitor" "loadbalancer_status" { count = "${var.status_enabled ? 1 : 0}" - name = "[${var.environment}] Load Balancer is down" + name = "[${var.environment}] Load Balancer is unreachable" message = "${coalesce(var.status_message, var.message)}" query = <