From 15549efc52e50e03a0b2d5165bdf41a121607947 Mon Sep 17 00:00:00 2001
From: Laurent Piroelle <laurent.piroelle@fr.clara.net>
Date: Mon, 30 Oct 2017 17:49:02 +0100
Subject: [PATCH] MON-77 Use data template for tag filter

---
 cloud/azure/eventhub/monitors-eventhub.tf | 31 +++++++++++++++--------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/cloud/azure/eventhub/monitors-eventhub.tf b/cloud/azure/eventhub/monitors-eventhub.tf
index 7c22418..71b97b3 100644
--- a/cloud/azure/eventhub/monitors-eventhub.tf
+++ b/cloud/azure/eventhub/monitors-eventhub.tf
@@ -1,9 +1,18 @@
+data "template_file" "filter" {
+  template = "$${filter}"
+
+  vars {
+    filter = "${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}"
+  }
+}
+
+
 resource "datadog_monitor" "eventhub_status" {
   name    = "[${var.environment}] Event Hub status"
   message = "${var.down_message}"
 
   query = <<EOF
-      avg(last_5m): avg:azure.eventhub_namespaces.status{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region} != 1
+      avg(last_5m): avg:azure.eventhub_namespaces.status{${data.template_file.filter.rendered} by {name,resource_group,region} != 1
       EOF
   type  = "query alert"
 
@@ -25,10 +34,10 @@ resource "datadog_monitor" "eventhub_failed_requests" {
 
   query = <<EOF
         avg(last_5m): (
-          avg:azure.eventhub_namespaces.failed_requests{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region}
+          avg:azure.eventhub_namespaces.failed_requests{${data.template_file.filter.rendered} by {name,resource_group,region}
         ) * 100 / (
-          avg:azure.eventhub_namespaces.successful_requests{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region} +
-          avg:azure.eventhub_namespaces.failed_requests{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region}
+          avg:azure.eventhub_namespaces.successful_requests{${data.template_file.filter.rendered} by {name,resource_group,region} +
+          avg:azure.eventhub_namespaces.failed_requests{${data.template_file.filter.rendered} by {name,resource_group,region}
         ) > ${var.failed_requests_rate_thresold_critical}
         EOF
   type  = "query alert"
@@ -56,14 +65,14 @@ resource "datadog_monitor" "eventhub_errors" {
 
   query = <<EOF
         avg(last_5m): (
-          avg:azure.eventhub_namespaces.internal_server_errors{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region} +
-          avg:azure.eventhub_namespaces.server_busy_errors{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region} +
-          avg:azure.eventhub_namespaces.other_errors{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region}
+          avg:azure.eventhub_namespaces.internal_server_errors{${data.template_file.filter.rendered} by {name,resource_group,region} +
+          avg:azure.eventhub_namespaces.server_busy_errors{${data.template_file.filter.rendered} by {name,resource_group,region} +
+          avg:azure.eventhub_namespaces.other_errors{${data.template_file.filter.rendered} by {name,resource_group,region}
         ) * 100 / (
-          avg:azure.eventhub_namespaces.successful_requests{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region} +
-          avg:azure.eventhub_namespaces.internal_server_errors{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region} +
-          avg:azure.eventhub_namespaces.server_busy_errors{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region} +
-          avg:azure.eventhub_namespaces.other_errors{${var.use_filter_tags == "true" ? format("dd_monitoring:enabled,dd_azure_eventhub:enabled,env:%s", var.environment) : "*"}} by {name,resource_group,region}
+          avg:azure.eventhub_namespaces.successful_requests{${data.template_file.filter.rendered} by {name,resource_group,region} +
+          avg:azure.eventhub_namespaces.internal_server_errors{${data.template_file.filter.rendered} by {name,resource_group,region} +
+          avg:azure.eventhub_namespaces.server_busy_errors{${data.template_file.filter.rendered} by {name,resource_group,region} +
+          avg:azure.eventhub_namespaces.other_errors{${data.template_file.filter.rendered} by {name,resource_group,region}
         ) > ${var.errors_rate_thresold_critical}
         EOF
   type  = "query alert"