From 0462972da6f80b0487968b86292d8ad3f84a11bf Mon Sep 17 00:00:00 2001
From: Quentin Manfroi <quentin.manfroi@fr.clara.net>
Date: Thu, 20 Sep 2018 16:03:32 +0200
Subject: [PATCH] MON-32 decrease threasholds for cache hit ratio

---
 cloud/aws/elasticache/memcached/inputs.tf             | 4 ++--
 cloud/aws/elasticache/memcached/monitors-memcached.tf | 2 +-
 cloud/aws/elasticache/redis/inputs.tf                 | 4 ++--
 cloud/aws/elasticache/redis/monitors-redis.tf         | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/cloud/aws/elasticache/memcached/inputs.tf b/cloud/aws/elasticache/memcached/inputs.tf
index 4f23bca..a07c61a 100644
--- a/cloud/aws/elasticache/memcached/inputs.tf
+++ b/cloud/aws/elasticache/memcached/inputs.tf
@@ -63,13 +63,13 @@ variable "get_hits_timeframe" {
 variable "get_hits_threshold_warning" {
   description = "Elasticache memcached get hits warning threshold in percentage"
   type        = "string"
-  default     = 20
+  default     = 80
 }
 
 variable "get_hits_threshold_critical" {
   description = "Elasticache memcached get hits critical threshold in percentage"
   type        = "string"
-  default     = 10
+  default     = 60
 }
 
 variable "cpu_high_silenced" {
diff --git a/cloud/aws/elasticache/memcached/monitors-memcached.tf b/cloud/aws/elasticache/memcached/monitors-memcached.tf
index 5a8369c..a79d226 100644
--- a/cloud/aws/elasticache/memcached/monitors-memcached.tf
+++ b/cloud/aws/elasticache/memcached/monitors-memcached.tf
@@ -1,6 +1,6 @@
 resource "datadog_monitor" "memcached_get_hits" {
   count   = "${var.get_hits_enabled ? 1 : 0}"
-  name    = "[${var.environment}] Elasticache memcached get hits {{#is_alert}}{{{comparator}}} {{threshold}}% ({{value}}%){{/is_alert}}{{#is_warning}}{{{comparator}}} {{warn_threshold}}% ({{value}}%){{/is_warning}}"
+  name    = "[${var.environment}] Elasticache memcached get hit ratio {{#is_alert}}{{{comparator}}} {{threshold}}% ({{value}}%){{/is_alert}}{{#is_warning}}{{{comparator}}} {{warn_threshold}}% ({{value}}%){{/is_warning}}"
   message = "${coalesce(var.get_hits_message, var.message)}"
 
   type = "metric alert"
diff --git a/cloud/aws/elasticache/redis/inputs.tf b/cloud/aws/elasticache/redis/inputs.tf
index 4e7a5d0..69e2024 100644
--- a/cloud/aws/elasticache/redis/inputs.tf
+++ b/cloud/aws/elasticache/redis/inputs.tf
@@ -63,13 +63,13 @@ variable "cache_hits_timeframe" {
 variable "cache_hits_threshold_warning" {
   description = "Elasticache redis cache hits warning threshold in percentage"
   type        = "string"
-  default     = 20
+  default     = 80
 }
 
 variable "cache_hits_threshold_critical" {
   description = "Elasticache redis cache hits critical threshold in percentage"
   type        = "string"
-  default     = 10
+  default     = 60
 }
 
 variable "cpu_high_silenced" {
diff --git a/cloud/aws/elasticache/redis/monitors-redis.tf b/cloud/aws/elasticache/redis/monitors-redis.tf
index 0a52bf5..92a3dcf 100644
--- a/cloud/aws/elasticache/redis/monitors-redis.tf
+++ b/cloud/aws/elasticache/redis/monitors-redis.tf
@@ -1,6 +1,6 @@
 resource "datadog_monitor" "redis_cache_hits" {
   count   = "${var.cache_hits_enabled ? 1 : 0}"
-  name    = "[${var.environment}] Elasticache redis cache hits {{#is_alert}}{{{comparator}}} {{threshold}}% ({{value}}%){{/is_alert}}{{#is_warning}}{{{comparator}}} {{warn_threshold}}% ({{value}}%){{/is_warning}}"
+  name    = "[${var.environment}] Elasticache redis cache hit ratio {{#is_alert}}{{{comparator}}} {{threshold}}% ({{value}}%){{/is_alert}}{{#is_warning}}{{{comparator}}} {{warn_threshold}}% ({{value}}%){{/is_warning}}"
   message = "${coalesce(var.cache_hits_message, var.message)}"
 
   type = "metric alert"